Migrate tests to JUnit5#555
Conversation
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup
|
Hi @strangelookingnerd! Thank you for your contribution! This PR will take some time to be reviewed :) |
All good, I'll try my best to resolve merge conflicts in the meantime. |
# Conflicts: # wayang-api/wayang-api-sql/src/test/java/org/apache/wayang/api/sql/SqlToWayangRelTest.java
|
Hi @strangelookingnerd, can you check and resolve the conflicts? Also some test is failing, if you could also check that it would be great. |
# Conflicts: # pom.xml # wayang-api/wayang-api-sql/src/test/java/org/apache/wayang/api/sql/SqlToWayangRelTest.java # wayang-applications/pom.xml # wayang-tests-integration/src/test/java/org/apache/wayang/tests/SparkIntegrationIT.java
# Conflicts: # wayang-tests-integration/src/test/java/org/apache/wayang/tests/SparkIntegrationIT.java
|
Fixed merge conflicts. |
|
Not really sure what is causing the test failures, any input would be appreciated. |
|
I'm not familiar with the new junit api, but the tests where the new changes fail are the tests that are supposed to cause an exception. 
|
|
@zkaoudi Apparently I'm getting snowblind looking at my own changes 😁 I think I got it now. |
|
Super! Everything works now! Thank you for the contribution :) |
2 participants
This PR aims to migrate all tests to JUnit5. Changes include:
I am well aware that this is a huge changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.
Why this is a good change:
It is important to notice that this change should not alter the test logic, but bring the project in line with modern best practices and help keeping it future-proof.